-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single quotes in framework interpolation #354
Conversation
Will actively review it in evening or so |
GitHub actions doesn't work right now, tested locally against arch linux node v16 ✔️ |
Thanks. Will you ship a 1.19.4 with that ? |
I'm currently reorder some stuff and think about to release a 1.20.0 🤔 |
@Shinigami92 when I was looking deep into the source code, I found that Vue3’s shortand |
If I remember correctly it could be somehow incompatible to pug's id literal 🤔 But I use |
I mean, I did not test it, I just didn't see the appropriate tests & implementation but I had probably missed something. I'll go deeper this evening and come back to you. |
Ok it is clear now.
Anyway, this is a very edge case, and who ever wants to pass a string prop which is curly-braces wrapped ? |
@Shinigami92 Nice util that |
@Shinigami92 do you have an idea of when you could release 1.20.0 ? In the meantime, I could really use the fix for our projects in production but as my vscode plugin has prettier/plugin-pug as an external dependencies (auto-resolved by prettier) I cann bundle the fix manually in it... |
Oh yeah, sure, I can release this this evening. Not sure why I did not 🤔 |
Neat ! Thank you @Shinigami92 |
I suppose this bug is related: With Once I define Then once changed to I‘d expect it to get formatted as: My
What I am doing wrong? |
@chrisjansky Before your issues goes under in this already closed and merged PR, could you at least open a new issue? |
Hi @Shinigami92, thanks for the quick reply–sorry for reopening this issue. I am not familiar with tests to be honest but I'll try opening a new PR. |
Added a new PR: #362 |
Fixes #339